Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group interface: Usability #277

Closed
1 of 2 tasks
koppor opened this issue Dec 22, 2017 · 2 comments · Fixed by JabRef/jabref#3715
Closed
1 of 2 tasks

Group interface: Usability #277

koppor opened this issue Dec 22, 2017 · 2 comments · Fixed by JabRef/jabref#3715
Labels
feature

Comments

@koppor
Copy link
Owner

koppor commented Dec 22, 2017 •
edited
Loading

  • double click on a group should open edit mode
  • When pressing +, the dialog should show "Add group" not "Edit group properties"

grafik
Escoul added a commit to Escoul/jabref that referenced this issue Feb 13, 2018
@Escoul
Changes regarding issue koppor#277:
1dfc4e5 
Fix the name of the group editing window to "Add group" instead of "Edit
Group" when adding a new group.
The group editing window can now also be called by double-clicking the
group to be edited.
@Escoul Escoul mentioned this issue Feb 13, 2018
Merged
5 tasks
@koppor koppor removed the PE1718 label Feb 14, 2018
@tobiasdiez
Copy link
Collaborator

@koppor I just stumbled upon a problem which resulted from the "double click = show edit dialog" change. Previously, it is was possible to expand/collapse groups by double clicking which now longer works since the edit dialog also pops up. I find both behaviors kind of natural but suspect that you expand/collapse more often than edit and would thus vote to revert JabRef#3715.

@tobiasdiez tobiasdiez reopened this Feb 25, 2018
@koppor
Copy link
Owner Author

koppor commented Feb 25, 2018

I would not completely revert the commit, because label of the dialog should be kept.

I am not working with group trees, but with flat groups, where the double click did nothing. For me, it is OK to revert that behavior.

@tobiasdiez tobiasdiez mentioned this issue Mar 11, 2018
Merged
6 tasks
koppor pushed a commit that referenced this issue Mar 17, 2023
Squashed 'buildres/csl/csl-locales/' changes from 9b9366b71b..47edde1be3
1fe8796 
47edde1be3 Translate original-work-published (#278)
0b6c4a3e5c Translate original-work-published (#277)

git-subtree-dir: buildres/csl/csl-locales
git-subtree-split: 47edde1be3056106783f881a3511b8446fae2c72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Group interface: Usability tweaks Escoul/jabref
2 participants
@koppor @tobiasdiez