Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOI: encoded URLs should be supported #3

Closed
koppor opened this issue Nov 6, 2015 · 2 comments
Closed

DOI: encoded URLs should be supported #3

koppor opened this issue Nov 6, 2015 · 2 comments
Labels
good first issue

Comments

@koppor
Copy link
Owner

koppor commented Nov 6, 2015

When building a DOI, strings like https://dx.doi.org/10.2307%2F1990888 should also be accepted
@stefan-kolb
Copy link
Collaborator

I think it is not possible to identify which parts of the DOI are escaped and which are not. Where is this a problem?

@koppor
Copy link
Owner Author

koppor commented Mar 28, 2017

The DOI specifcation talks about encoding at https://www.doi.org/doi_handbook/2_Numbering.html#htmlencoding. I don't remember, where I hit the issue, but I never saw DOIs containing a real % (and not used for encoding) in the wild... Possibly, whenever the DOI is an URL (http...), decoding should be applied.

@koppor koppor mentioned this issue Mar 28, 2017
Open
@johannes-manner johannes-manner mentioned this issue Feb 6, 2018
Merged
5 tasks
@koppor koppor closed this as completed Feb 28, 2018
koppor pushed a commit that referenced this issue Aug 2, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharelatex
ada867a 
* upstream/master: (47 commits)
  Fix Google Scholar fetcher
  Use english for all LCID mappings JabRef#1851
  remove import preferences test mock import and convert to junit5
  fix JabRef#3693 (JabRef#3702)
  Fix space leads to jump in entry editor (JabRef#3699)
  Fix JabRef#3669
  Extract creation of the contents of FileAnnotationTabController
  Fix changelog
  Fix NPE
  Remove unnecessary file
  use processbuilder for calling external apps
  Fix color highlight of odd linked files
  Fixes JabRef#2964
  Fix koppor issues #3
  Allow spaces in DOIs
  Remove irrelevant log messages during XMP reading
  Adapt log4j configuration for cleaner junit tests JabRef#3511
  Eclipse Django style JabRef#3655
  Better code style for chained methods
  Update build.gradle
  ...
koppor pushed a commit that referenced this issue Nov 2, 2022
@Gpax971 @Siedlerchr
Group context menu presents relevant options depending on number of s…
079c27b 
…ubgroups (JabRef#9286)

* Closes issue #1, opens issues #3, #4

* Adjusted removeGroupNoSubgroups to keep consistent with other removeGroup__ methods

* Update context menu each time it is opened, to reflect any changes that may have been made to subgroups
Adjusted removeSubgroups.setOnAction to be consistent with other action events

* Update CHANGELOG.md

* Removed "Remove subgroups" and "Sort subgroups" options when no subgroups present

* Removed context submenu addition from event listener

* Fixed JavaDoc for removeGroupNoSubgroups

* Added remove text to language file

* Fixed popup when deleting group with no subgroups

Co-authored-by: Christoph <siedlerkiller@gmail.com>
koppor pushed a commit that referenced this issue Apr 3, 2023
@JacobTrossing
Merge pull request #3 from JacobTrossing/feat-#1
4c06177 
(Feat): #1 Added test for storage of proxy preferences
koppor pushed a commit that referenced this issue Mar 12, 2024
@LinusWallin @karlsb @burcukilic
Resolve requested "nitpicks" and warnings. (#7) (JabRef#10960)
985b40b 
* Adds feature CleanupJob for removing non-existent files (#2)

* feat: RemoveLinksToNotExistentFiles.java

* feat: added option to cleanup entries

* feat: improved cleanup entry dialogue

* Test: implements test for linked files which exist

Implementation of a test which calls the cleanup functionality of
RemoveLinksToNotExistentFiles with a entry that is linked to an existing
file. The test makes sure that no changes are made since the linked
file exists.

* Refactor: refactored test to match the standard of the project

Removed the JavaDoc comment from the test, since other tests in the
project don't have JavaDoc:s. Also removed test from the name of the
test function, as it seems that the standard way of naming tests
is to not have test in the testfunctions name.

* Refactor: removed system.out.print()

Removed an print from the tests.

* fix: non english character deleted

* Docs: Added information about changes

Added information about the changes made for solving issue#10929
to the CHANGES.md file.

---------



* Fix: Removes unused imports and solves other errors

Removes unused imports and solves the error of language keys
that were not in the english laguage file.

* Fix: Removes empty line and solves other issues

Removes an empty line where 2 empty lines appear in after each
other. Also adds brackets to URL and removes an key which is
not in the english language file and was missed in the last commit.

* Docs: Removes technicality from changelog

Removes technical details for the change made in changelog and also
follows the suggestion for removing the space and brackets between
the link and the issue.

* test: enhanced RemoveLinksToNotExistentFilesTest (#3)

* test: enhanced RemoveLinksToNotExistentFilesTest

* test: add real content

* test: change structure

* test: added expectedChanges

* test: added a third test to RemoveLinksToNotExistentFilesTest

* refactor: removed unnecessary toString

* style: removed a whitespace

* refactor: checkstyle formatting.

formatted files according to checkstyle plugin.

---------



* Resolve request changes (#4)

* test: enhanced RemoveLinksToNotExistentFilesTest

* test: add real content

* test: change structure

* test: added expectedChanges

* test: added a third test to RemoveLinksToNotExistentFilesTest

* refactor: removed unnecessary toString

* style: removed a whitespace

* refactor: checkstyle formatting.

formatted files according to checkstyle plugin.

* refactor: replaced .get(0) with .getFirst() for first accessing element of List.

Changed was required from ./gradlew rewriteDryRun

---------



* Resolve more request changes and warnings (#5)

* Reverse the condition and the content in RemoveLinksToNotExistentFiles

Resolves comment
 "Reverse the condition and the content.

Reason: You have BOTH (true and false) cases covered. The true case should normally come first."

* Fix: Store bibFolder.resolve("test.bib") in a variable

* Refactor: Rename variable fileFolder to originalFileFolder and remove comment.

* Refactor: Rename defaultFileFolder to newFileFolder

* Refactor: Fix indentation in RemoveLinksToNotExistentFilesTest

* Refactor: Replaced Arrays.asList() with List.of()

* Refactor: Replaced Arrays.asList() with List.of()

* Refactor: Change to use java.nio for file deletion.

* Refactor: Move comment to line above.

* Refactor: Added "PDF" as third argument to LinkedFile for OnlineLink files

* Refactor: Removed unused variables in RemoveLinksToNotExistentFiles

* Refactor: Throw IOException in RemoveLinksToNotExistentFilesTest functions

* Refactor: Tests assert using List.of() in RemoveLinksToNotExistentFilesTest

* Refactor: Corrected Arguments for LinkedFile in RemoveLinksToNotExistentFilesTest

* Refactor: Class fields into local variables

This refactor fixed 3 warnings.

* docs: updated docs to remove merge conflict

---------

Co-authored-by: karlsb <36365664+karlsb@users.noreply.github.com>
Co-authored-by: burcukilic <94201593+burcukilic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koppor @stefan-kolb