Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement better scaling of main table showing entries #644

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from
Draft

Implement better scaling of main table showing entries #644

wants to merge 38 commits into from

Conversation

koppor
Copy link
Owner

@koppor koppor commented May 7, 2023

Preserving JabRef#7181.

### Compulsory checks
- [ ] Change in `CHANGELOG.md` described in a way that is understandable for the average user (if applicable)
- [ ] Tests created for changes (if applicable)
- [ ] Manually tested changed features in running JabRef (always required)
- [ ] Screenshots added in PR description (for UI changes)
- [ ] [Checked developer's documentation](https://devdocs.jabref.org/): Is the information available and up to date? If not, I outlined it in this pull request.
- [ ] [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request to the documentation repository.

koppor and others added 30 commits December 12, 2020 23:44
@koppor @DominikVoigt
Implement better scaling of main table showing entries
a1a5ccc 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor
Fix number
e91bb8d
@koppor @calixtus @DominikVoigt
Remove resizeColumnsToFit
8f522df 
- Remove preferences
- Remove MainTablePreferences (and migrate left-overs into ColumnPreferences)
- Fix name of "Show dedicated file columns" (instead of "Show extra columns")

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor
Fix checkstyle
1acd12e
@koppor
Merge branch 'master' into fix-967
c8caa13
@koppor @DominikVoigt
Add smart resize if content fits into table width
f5e2d9f 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor @DominikVoigt
Address some comments
bcea66c 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor @DominikVoigt
WIP
6da49b2 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor @DominikVoigt
Speedup processResources
dfac705 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor
Merge branch 'speedup-process-resources' into fix-967
057ae9f
@koppor @DominikVoigt
Try path without ./ at the beginning
8834fb6 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor @DominikVoigt
Output java error on console, too
5b6f0d8 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor @DominikVoigt
Use LOGGER instead of System.err
fd80c30 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor
Merge branch 'fix-output-with-wrong-jdk-version' into fix-967
c64b5e3
@koppor
Merge branch 'speedup-process-resources' into fix-967
9f56fd5
@koppor @DominikVoigt
Fix scroll bar still present
d15e90f 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor @DominikVoigt
MinWidth to 80
7de21ad 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor
Merge branch 'master' into fix-967
8c7cd7a
@koppor
Merge branch 'fix-967' of github.com:JabRef/jabref into fix-967
f7186f3
@koppor @DominikVoigt
WIP (does not work)
80557f2 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor
Merge remote-tracking branch 'origin/master' into fix-967
043a0cc
@koppor
Fix ordering in CHANGELOG.md
c3b02e3
@koppor @DominikVoigt
WIP
fd118a6 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor @DominikVoigt
WIP - "User changed column size in a way that window can contain all …
f0788f6 
…the columns" still a TODO

Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor @DominikVoigt
Add documentation on implementation idea
a1633a1 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor @DominikVoigt
Refine description (and change TableColumnBase to TableColumn)
73d5448 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor @DominikVoigt
Cases I0 to I3
f75831d 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor
First proposal of case names
c417d7d
@koppor @DominikVoigt
WIP: Reimplement logic according to comments
496e505 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor
Merge remote-tracking branch 'origin/master' into fix-967
466731f
koppor and others added 8 commits January 7, 2021 16:29
@koppor @DominikVoigt
WIP
caf1e23 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor
Merge remote-tracking branch 'origin/master' into fix-967
63af8fd
@koppor @DominikVoigt
Resizing of colomms works
274e109 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor @DominikVoigt
Use EPSILON_MARGIN also for "content has fit into table before"
910c592 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor
Merge branch 'master' into fix-967
513c68c
@calixtus
Merge remote-tracking branch 'upstream/master' into fix-967
286e7f9 
# Conflicts:
#	src/main/java/org/jabref/gui/maintable/MainTable.java
#	src/main/java/org/jabref/gui/preferences/table/TableTabViewModel.java
@koppor
Merge branch 'main' into fix-967
caf7232 
Needed to add "preferences.getColumnPreferences().isDedicatedFileColumnsEnabled()))" to PersitenceVisualStateTable.java

# Conflicts:
#	docs/adr/0016-mutable-preferences-objects.md
#	src/main/java/org/jabref/gui/maintable/PersistenceVisualStateTable.java
#	src/main/java/org/jabref/gui/maintable/SmartConstrainedResizePolicy.java
#	src/main/resources/l10n/JabRef_en.properties
@koppor
Merge branch 'main' into fix-967
609f6a2
@koppor koppor mentioned this pull request May 7, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @calixtus