Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify a custom transformation to apply to the current Bitmap #259

Merged
merged 2 commits into from
Mar 25, 2016
Merged

Add ability to specify a custom transformation to apply to the current Bitmap #259

merged 2 commits into from
Mar 25, 2016

Conversation

mbrubin56
Copy link

  • Add a new interface, Transform, that clients can implement to apply a custom transformation to the GIF's current Bitmap.
  • Reimplemented the rounded corners implementation as an implementation of Transform.

…t Bitmap.

* Add a new interface, Transform, that clients can implement to apply a custom transformation to the GIF's current Bitmap.
* Reimplemented the rounded corners implementation as an implementation of Transform.
@codecov-io
Copy link

Current coverage is 3.91%

Merging #259 into master will decrease coverage by -0.06% as of 7c593bd

@@            master   #259   diff @@
=====================================
  Files           22     23     +1
  Stmts         1181   1200    +19
  Branches       170    173     +3
  Methods          0      0       
=====================================
  Hit             47     47       
  Partial          5      5       
- Missed        1129   1148    +19

Review entire Coverage Diff as of 7c593bd

Powered by Codecov. Updated on successful CI builds.

@koral--
Copy link
Owner

koral-- commented Mar 14, 2016

Thanks, apart from comments above LGTM.

@mbrubin56
Copy link
Author

Thanks for the comments! I agree with them (sorry I mistranslated that corner radius from a float to an int). Everything should be addressed with ac83411.

@mbrubin56
Copy link
Author

Oh, and I should also take the time to thank you for the lovely library.

koral-- added a commit that referenced this pull request Mar 15, 2016
koral-- added a commit that referenced this pull request Mar 15, 2016
@koral--
Copy link
Owner

koral-- commented Mar 15, 2016

Merged into dev branch with minor tweaks. This PR will be closed automatically when commit gets merged into the master.

koral-- added a commit that referenced this pull request Mar 15, 2016
koral-- added a commit that referenced this pull request Mar 19, 2016
@koral-- koral-- merged commit ac83411 into koral--:master Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants