Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: heuristic find header - blank lines after first comments should terminate #112

Merged
merged 4 commits into from
Jan 3, 2024
Merged

fix: heuristic find header - blank lines after first comments should terminate #112

merged 4 commits into from
Jan 3, 2024

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Jan 3, 2024

This closes #110.

cc @tanruixiang @spencercjh

Signed-off-by: tison <wander4096@gmail.com>
…terminate

Signed-off-by: tison <wander4096@gmail.com>
@spencercjh
Copy link

It's a fix that fits my instincts. 😆

image

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Member Author

tisonkun commented Jan 3, 2024

Waiting for @tanruixiang's reply. I'm scheduling to do a release later this week.

Copy link

@tanruixiang tanruixiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@tisonkun tisonkun merged commit 17ca54d into korandoru:main Jan 3, 2024
10 checks passed
@tisonkun tisonkun deleted the heuristic-header branch January 3, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

format will remove the comment by mistake
3 participants