fix: Add main sourceSet output to the inputs #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
As discussed in the issue, the
resolveSources()
method is adding the main sourceSet output to the list of files sent to jandex.jandex-gradle-plugin/src/main/groovy/org/kordamp/gradle/plugin/jandex/tasks/JandexTask.groovy
Lines 155 to 157 in 8b9f879
So for me this belongs to the task input in order to avoid the task to stay
UP-TO-DATE
when there is a change.There was no guidance on functional tests in this repository.
So I used what is generated by
gradle init
as input but I did not used Spock.If the setup is not the one that is expected, feel free to point me to other repositories where you have already functional tests.
Or if you prefer not having them, this can also be removed from this PR.
The test itself contains the reproducer provided by @jskillin-idt and makes sure that the outcome of the jandex task is correct (
SUCCESS
orUP_TO_DATE
) depending if there was a source modification or not.