Skip to content

Commit

Permalink
fix: Remove use of compile/runtime configurations from integration/fu…
Browse files Browse the repository at this point in the history
…nctional test plugins
  • Loading branch information
aalmiray committed Dec 15, 2023
1 parent 6deecff commit 0c22df1
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 31 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,8 @@ class FunctionalTestPlugin extends AbstractKordampPlugin {

@CompileStatic
private void adjustConfigurations(Project project) {
String compileSuffix = 'Compile'
String runtimeSuffix = 'Runtime'
if (supportsApiConfiguration(project)) {
compileSuffix = 'Implementation'
runtimeSuffix = 'RuntimeOnly'
}
String compileSuffix = 'Implementation'
String runtimeSuffix = 'RuntimeOnly'

project.configurations.findByName('functionalTest' + compileSuffix)
.extendsFrom project.configurations.findByName(compileSuffix.uncapitalize())
Expand All @@ -138,15 +134,8 @@ class FunctionalTestPlugin extends AbstractKordampPlugin {
}

private void createConfigurationsIfNeeded(Project project) {
String compileSuffix = 'Compile'
String runtimeSuffix = 'Runtime'
if (supportsApiConfiguration(project)) {
compileSuffix = 'Implementation'
runtimeSuffix = 'RuntimeOnly'
}

project.configurations.maybeCreate('functionalTest' + compileSuffix)
project.configurations.maybeCreate('functionalTest' + runtimeSuffix)
project.configurations.maybeCreate('functionalTestImplementation')
project.configurations.maybeCreate('functionalTestRuntimeOnly')
}

private void createSourceSetsIfNeeded(Project project) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import javax.inject.Named
import static org.kordamp.gradle.listener.ProjectEvaluationListenerManager.addProjectEvaluatedListener
import static org.kordamp.gradle.util.PluginUtils.resolveConfig
import static org.kordamp.gradle.util.PluginUtils.resolveSourceSets
import static org.kordamp.gradle.util.PluginUtils.supportsApiConfiguration

/**
* @author Andres Almiray
Expand Down Expand Up @@ -115,12 +114,8 @@ class IntegrationTestPlugin extends AbstractKordampPlugin {

@CompileStatic
private void adjustConfigurations(Project project) {
String compileSuffix = 'Compile'
String runtimeSuffix = 'Runtime'
if (supportsApiConfiguration(project)) {
compileSuffix = 'Implementation'
runtimeSuffix = 'RuntimeOnly'
}
String compileSuffix = 'Implementation'
String runtimeSuffix = 'RuntimeOnly'

project.configurations.findByName('integrationTest' + compileSuffix)
.extendsFrom(project.configurations.findByName('test' + compileSuffix))
Expand All @@ -144,15 +139,8 @@ class IntegrationTestPlugin extends AbstractKordampPlugin {
}

private void createConfigurationsIfNeeded(Project project) {
String compileSuffix = 'Compile'
String runtimeSuffix = 'Runtime'
if (supportsApiConfiguration(project)) {
compileSuffix = 'Implementation'
runtimeSuffix = 'RuntimeOnly'
}

project.configurations.maybeCreate('integrationTest' + compileSuffix)
project.configurations.maybeCreate('integrationTest' + runtimeSuffix)
project.configurations.maybeCreate('integrationTestImplementation')
project.configurations.maybeCreate('integrationTestRuntimeOnly')
}

private void createSourceSetsIfNeeded(Project project) {
Expand Down

0 comments on commit 0c22df1

Please sign in to comment.