-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve communication of Kord 'ready' states #55
Comments
This will be served in 0.7.x due to the mentioned breaking changes I assume? |
It doesn't have to be a breaking change, at least not all of it. |
Fair enough 👍 |
To come back to this after a while, the following has been concluded:
kord.on<GuildCreateEvent> {
guild.requestMembers().collect()
} The idea of making the event then 'pluggable' becomes obsolete; all users will be cached after the As such, the |
Since I am not sure why this got closed I am reopening this |
Bot authors may want to wait for Kord to have done its initial setup, this'll mostly involve waiting until the Gateway has send all initial cacheable data. They may incorrectly come to the conclusion that the
ReadyEvent
fits their needs.Kord's
ReadyEvent
is a representation of Discord's Gateway READY event and indicates that the gateway is ready to accept commands.To clear up this confusion, and introduce the missing functionality, I suggest the following changes:
ReadyEvent
toGatewayReadyEvent
to better communicate the intention of this event.KordReadyEvent
to signal the completion of initial gateway traffic.Furthermore, we may want to make this
KordReadyEvent
'pluggable', to allow certain actions like fetching members via the gateway to cache them before this event gets fired.The text was updated successfully, but these errors were encountered: