This repository has been archived by the owner on May 20, 2024. It is now read-only.
Enable guild caching #206
Closed
Enable guild caching #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds like a bad idea |
DRSchlaubi
suggested changes
Jun 5, 2021
|
The problem here isn't that the Guild cache isn't enabled. It's that you try to fetch the guild before the ready event get's fired so the guild can't be cached yet and has to be resolved through rest. The guild cache is enabled per default and this shouldn't change anything Also let's poke @BartArys to fix: kordlib/kord#55 |
|
Thanks for the clarification |
Closed
DRSchlaubi
reviewed
Aug 3, 2021
Comment on lines
+81
to
+85
| cache { | ||
| guilds { cache, description -> | ||
| MapEntryCache(cache, description, MapLikeCollection.concurrentHashMap()) | ||
| } | ||
| } |
There was a problem hiding this comment.
This still won't have any effect since guild caching is a thing that is enabled by default
|
This PR will be superseded buy an upcoming PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will (hopefully) solve the issue that the member count is null on /info