Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support kord-voice on Kotlin/JS and Windows #69

Open
8 tasks done
BartArys opened this issue Sep 21, 2020 · 12 comments · Fixed by #775 · May be fixed by #855
Open
8 tasks done

Support kord-voice on Kotlin/JS and Windows #69

BartArys opened this issue Sep 21, 2020 · 12 comments · Fixed by #775 · May be fixed by #855
Assignees
@DRSchlaubi

Comments

@BartArys
Copy link
Contributor

BartArys commented Sep 21, 2020 •
edited by DRSchlaubi
Loading

Since 0.9.0 Kotlin/JS is officially supported, see #775 and 0.9.0 for more information, for progress on Kotlin/Native check #855

kord-voice
@DRSchlaubi DRSchlaubi mentioned this issue Jan 9, 2021
Open
@DRSchlaubi
Copy link
Member

Kotlin/kotlinx.coroutines#462 got closed, so we actually have multithreaded coroutines on native now

@DRSchlaubi DRSchlaubi mentioned this issue Apr 17, 2022
Closed
@DRSchlaubi
Copy link
Member

DRSchlaubi commented Apr 18, 2022 •
edited
Loading

Web socket support on native seems to exist (although I couldn't really test that yeet) however you cannot use TLS connections on native

WS support is there now as ktorio/ktor@e7c8c03 got merged

however there is no wss support yet

@lukellmann lukellmann mentioned this issue Apr 20, 2022
Merged
@silenium-dev
Copy link

Regarding the stable memory model for native, the new memory manager is now stable and used by default (https://kotlinlang.org/docs/native-memory-manager.html).

@lukellmann
Copy link
Member

It's technically in Beta but so are Kotlin/Native and Kotlin Multiplatform: https://kotlinlang.org/docs/components-stability.html#current-stability-of-kotlin-components

@DRSchlaubi DRSchlaubi pinned this issue Feb 26, 2023
@DRSchlaubi
Copy link
Member

DRSchlaubi commented Feb 26, 2023 •
edited
Loading

Currently, a WIP MPP version of kord is on the feature/mpp branch. Is supports almost all features (except voice) on both JVM and JS

@DRSchlaubi DRSchlaubi mentioned this issue Mar 20, 2023
Open
6 tasks
@DRSchlaubi DRSchlaubi mentioned this issue Apr 5, 2023
Merged
lukellmann added a commit that referenced this issue Apr 5, 2023
@DRSchlaubi @lukellmann
Support Kotlin/JS (#775)
64f6636 
This commit attempts to provide Kotlin/JS support for Kord (see #69)

Breaking Changes:

 * The following member functions were replaced by extension functions.
   Importing the extension functions should fix this breaking change.
   * dev.kord.common.Locale.asJavaLocale ->
     import dev.kord.common.asJavaLocale
   * dev.kord.core.cache.KordCacheBuilder.lruCache ->
     import dev.kord.core.cache.lruCache
   * dev.kord.rest.builder.message.create.MessageCreateBuilder.addFile
     -> import dev.kord.rest.builder.message.create.addFile
   * dev.kord.rest.builder.message.modify.MessageModifyBuilder.addFile
     -> import dev.kord.rest.builder.message.modify.addFile
   * dev.kord.rest.request.RequestBuilder.file ->
     import dev.kord.rest.request.file

 * The type of the following declarations was changed from
   java.util.Locale to dev.kord.common.Locale:
   * dev.kord.core.entity.Guild.preferredLocale
   * dev.kord.rest.builder.guild.GuildModifyBuilder.preferredLocale

 * All annotations in dev.kord.common.annotation and the
   dev.kord.gateway.PrivilegedIntent annotation now have BINARY instead
   of RUNTIME retention. This means they are no longer visible for
   reflection.

 * All maven consumers must append '-jvm' to their artifact IDs for
   kord-common, kord-rest, kord-gateway and kord-core.

 * The core-voice capability has been removed, please use the
   kord-core-voice artifact instead.

---------

Co-authored-by: Lukellmann <lukellmann@gmail.com>
@lukellmann lukellmann changed the title Status of Mutliplatform Status of Multiplatform Apr 8, 2023
@russellbanks russellbanks mentioned this issue May 16, 2023
Open
@DRSchlaubi DRSchlaubi linked a pull request Aug 5, 2023 that will close this issue
Open
9 tasks
This was linked to pull requests Aug 6, 2023
Support Kotlin/Native #855
Open
Support Kotlin/JS #775
Merged
@DRSchlaubi DRSchlaubi mentioned this issue Aug 31, 2023
Merged
lukellmann added a commit that referenced this issue Sep 3, 2023
@DRSchlaubi @lukellmann
Don't use value class Reset with AtomicRef (#863)
7ae3daf 
The use of value classes for the Reset class has already caused issues
implementing #855. However, it was isolated to native platforms.
Unfortunately, this behavior will become a compiler error soon, so we
need to change it. This can be achieved by simply using the backing
Instant instead of Reset with AtomicRef.

Related Issues:
#855
#69
Kotlin/kotlinx-atomicfu#291
https://youtrack.jetbrains.com/issue/KT-61584

Co-authored-by: lukellmann <lukellmann@gmail.com>
@Xinerfapre
Copy link

Is it possible to add Kotlin/Wasm compatibility ?

@DRSchlaubi
Copy link
Member

Is it possible to add Kotlin/Wasm compatibility ?

We don't really see the point behind running Kord in the browser, since it only supports the bot api and not the OAuth API, so we don't have a checklist for WASM suppor

@lukellmann
Copy link
Member

targetting wasmWasi might be a thing to do in the future though

@lukellmann
Copy link
Member

and wasm can also be run in node iirc, so even adding wasmJs might be possible

@DRSchlaubi
Copy link
Member

ktorio/ktor#3950

@DRSchlaubi DRSchlaubi self-assigned this Jan 30, 2024
@DRSchlaubi DRSchlaubi changed the title Status of Multiplatform Support kord-voice on Kotlin/JS and Windows Mar 10, 2024
@DRSchlaubi
Copy link
Member

Ktor 3.1.0 will have JS support for voice: https://youtrack.jetbrains.com/issue/KTOR-6004/Support-NodeJs-target-for-ktor-network

@DRSchlaubi
Copy link
Member

Maybe @lost-illusi0n, @viztea and @lukellmann can chime in for items required for DAVE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DRSchlaubi DRSchlaubi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Kotlin/JS kordlib/kord
Support Kotlin/Native kordlib/kord
5 participants
@DRSchlaubi @BartArys @silenium-dev @Xinerfapre @lukellmann