FB: Refactor refresh rectangle bounding checks #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will replace our funky checkBounds use-cases where we actually want to fit a rectangel inside a bb, without actually relying on half the checkBounds feature, which are designed for ccordinates checking when blitting. Fold in support for alignment constraints, which allow us to make sure they don't do stupid things that would break OOB, as was experienced on Bellatrix3...
mandatory) I hadn't consciously dropped the nil guards, but turns out it makes sense, because UIManager will *always* set them. Thanks to @mergen3107 foir catching that one early ;)
It doesn't actually do anything with the dimensions, nor should it given its name...
This was referenced Dec 31, 2023
Which does what getScreenMode probably meant to be doing, i.e., returns the layout relative to the rotation, not how the buffer actually looks like ;).
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Dec 31, 2023
Pending the actual fix from koreader/koreader-base#1718 that'll hit after the release.
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Dec 31, 2023
Pending the actual fix from koreader/koreader-base#1718 that'll hit after the release.
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Dec 31, 2023
Pending the actual fix from koreader/koreader-base#1718 that'll hit after the release.
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Dec 31, 2023
Pending the actual fix from koreader/koreader-base#1718 that'll hit after the release.
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Dec 31, 2023
Pending the actual fix from koreader/koreader-base#1718 that'll hit after the release.
We need to rotate our shadow before *before* inverting it, otherwise we will paint in the wrong orientation, potentially to off-screen regions if a viewport is in effect.
of a viewport (if any) Fix koreader/koreader#11316
accurate It's also not actually the physical rect, as the rectangle honors rotation, while the physical buffer layout is always unrotated.
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Jan 9, 2024
Pending the actual fix from koreader/koreader-base#1718 that'll hit after the release.
NiLuJe
commented
Jan 12, 2024
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Jan 12, 2024
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Jan 12, 2024
* UIManager: Init a full Geom on region-less refreshes in _refresh * Never call refreshFull with no arguments I got rid of the low-level nil guards, because UIManager itself guarantees that it can never happen * Bump base (koreader/koreader-base#1718) (fix #11303) * Kindle: Re-enable HW dithering on the Scribe Now that the underlying issue is fixed in base ;).
NiLuJe
added a commit
to NiLuJe/koreader-base
that referenced
this pull request
Jan 13, 2024
Missed the _updateFull call site in koreader#1718 Fix koreader/koreader#11348
NiLuJe
added a commit
that referenced
this pull request
Jan 13, 2024
Missed the _updateFull call site in #1718 Fix: koreader/koreader#11348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
koreader/koreader#11303 showed that the current alignment trickery for HW dithering on mxcfb was a bit shoddy, so refactor the whole thing to do everything at once, in a function actually designed for that use case, instead of re-purposing a blitting helper...
This change is