mupdf: allow memory streams to load resources #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use fz_open_document_with_stream_and_dir instead of fz_open_document_with_stream to allow MuPDF to load resources (images and CSS) when it is loading a HTML document from a memory stream.
TnS-hun
added a commit
to TnS-hun/koreader
that referenced
this pull request
Dec 8, 2024
Pass the directory that contains the dictionary's ifo file to Mupdf.openDocumentFromText to allow MuPDF to display images referenced by HTML dictionaries. Depends on: koreader/koreader-base#2002 Fixes: koreader#12628
Frenzie
reviewed
Dec 8, 2024
| local mupdf_doc = { | ||
| doc = W.mupdf_open_document_with_stream(ctx, magic, stream), | ||
| doc = W.mupdf_open_document_with_stream_and_dir(ctx, magic, stream, archive), |
There was a problem hiding this comment.
Yes, it is fine with null. The previously used fz_open_document_with_stream just a single line function that uses null as the archive.
Frenzie
approved these changes
Dec 8, 2024
TnS-hun
added a commit
to TnS-hun/koreader
that referenced
this pull request
Dec 9, 2024
Pass the dictionary's res directory to Mupdf.openDocumentFromText to allow MuPDF to display images referenced by HTML dictionaries. Depends on: koreader/koreader-base#2002 Fixes: koreader#12628
TnS-hun
added a commit
to TnS-hun/koreader
that referenced
this pull request
Dec 9, 2024
Pass the dictionary's res directory to Mupdf.openDocumentFromText to allow MuPDF to display images referenced by HTML dictionaries. Depends on: koreader/koreader-base#2002 Fixes: koreader#12628
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Dec 11, 2024
Includes: * sqlite: update to 3.47.2 (koreader/koreader-base#1999) * mupdf: fix finalizers (koreader/koreader-base#2001) * mupdf: allow memory streams to load resources (koreader/koreader-base#2002) for #12877 * thirdparty/lua-Spore 0.3.4 (koreader/koreader-base#2003)
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Dec 12, 2024
Pass the dictionary's res directory to Mupdf.openDocumentFromText to allow MuPDF to display images referenced by HTML dictionaries. Depends on: koreader/koreader-base#2002 Fixes: #12628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use fz_open_document_with_stream_and_dir instead of fz_open_document_with_stream to allow MuPDF to load resources (images and CSS) when it is loading a HTML document from a memory stream.
This change is