Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to libressl #2010

Merged
merged 3 commits into from
Dec 29, 2024
Merged

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Dec 16, 2024

Alternative to #2009.


This change is Reviewable

@benoit-pierre
Copy link
Contributor Author

Doh! So close…

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  CMake 3.16.4 or higher is required.  You are running version 3.16.3

@benoit-pierre
Copy link
Contributor Author

I don't see anything in the CMake 3.16 release notes that would prevent downgrading the requirement to 3.16.3.

- this is the version used by our Docker images
- LibreSSL needs at least 3.16.4 (which should be safely downgradable to 3.16.3)
@benoit-pierre benoit-pierre marked this pull request as ready for review December 25, 2024 09:44
@Frenzie Frenzie merged commit 9c75c5a into koreader:master Dec 29, 2024
4 checks passed
@benoit-pierre benoit-pierre deleted the pr/switch_to_libressl branch December 29, 2024 09:02
benoit-pierre added a commit to benoit-pierre/koreader that referenced this pull request Dec 29, 2024
Frenzie pushed a commit to koreader/koreader that referenced this pull request Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants