Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always compile with debug information #2022

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Jan 26, 2025

Each binary's debug information are extracted and linked to a separate .dbg file. Those .dbg files are ignored when bundling a release, but otherwise transparently used by gdb, addr2line, and other tools when present.


This change is Reviewable

Each binary's debug information are extracted and linked to a separate
`.dbg` file. Those `.dbg` files are ignored when bundling a release,
but otherwise transparently used by gdb, addr2line, and other tools
when present.
@benoit-pierre
Copy link
Contributor Author

Note: for macOS, dsymutil is used to split the debug information into a separate .dSYM bundle that should work the same (untested, as I don't have access to a machine for checking).

@Frenzie
Copy link
Member

Frenzie commented Jan 26, 2025

I suppose it might be a tad slower to build, but the runtime performance is identical?

@benoit-pierre
Copy link
Contributor Author

Yep.

@Frenzie Frenzie merged commit d198818 into koreader:master Jan 26, 2025
4 checks passed
@benoit-pierre benoit-pierre deleted the pr/always_compile_with_debug_information branch January 26, 2025 19:03
benoit-pierre added a commit to benoit-pierre/koreader that referenced this pull request Jan 26, 2025
Frenzie pushed a commit to koreader/koreader that referenced this pull request Jan 27, 2025
Commodore64user pushed a commit to Commodore64user/KOReader_fork that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants