Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lodepng: update to 0b1d9cc (2024-12-28) #2026

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Jan 27, 2025

lvandeve/lodepng@d398e0f...0b1d9cc

Additionally, compile without support for ancillary / unknown chunks.

Code size difference in release mode:

  • Android ARM64: -13.6 KB
  • Emulator x86_64: -14.2 KB
  • Kindle PW2: -8.1 KB

This change is Reviewable

@Frenzie
Copy link
Member

Frenzie commented Jan 27, 2025

For reference:
https://www.w3.org/TR/png/#11Ancillary-chunks

It would seem that in this case it only directly refers to suggested background color and the text values.
https://github.com/fhanau/Efficient-Compression-Tool/blob/9aabc23d73899ae55c1de292592fed6eb6217f66/src/lodepng/lodepng.h#L268-L348

@Frenzie Frenzie merged commit 3670d05 into koreader:master Jan 28, 2025
4 checks passed
@benoit-pierre benoit-pierre deleted the pr/lodepng_update branch January 28, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants