feat: 최상단 헤더에 봇 / 서버 표시 #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
skinmaker1345
commented
Mar 29, 2025
skinmaker1345
commented
- 최상단 헤더에 봇 / 서버를 표기하여 UX를 개선합니다.
wonderlandpark
requested changes
Mar 29, 2025
Member
wonderlandpark
left a comment
wonderlandpark
left a comment
There was a problem hiding this comment.
possible undefined returning for type all
components/Hero.tsx
Outdated
| <Container className='pb-16 pt-24 md:pb-20' ignoreColor> | ||
| <h1 className='hidden text-left text-3xl font-bold md:block'> | ||
| {header && `${header} - `}한국 디스코드 리스트 | ||
| {header && `${header} - `} {{ bots: '봇 | ', servers: '서버 | ' }[type]}한국 디스코드 |
Member
There was a problem hiding this comment.
Suggested change
| {header && `${header} - `} {{ bots: '봇 | ', servers: '서버 | ' }[type]}한국 디스코드 | |
| {header && `${header} - `} {{ bots: '봇 | ', servers: '서버 | ' }[type] || ''}한국 디스코드 |
components/Hero.tsx
Outdated
| </span> | ||
| )} | ||
| 한국 디스코드 리스트 | ||
| {{ bots: '봇 | ', servers: '서버 | ' }[type]}한국 디스코드 리스트 |
Member
There was a problem hiding this comment.
Suggested change
| {{ bots: '봇 | ', servers: '서버 | ' }[type]}한국 디스코드 리스트 | |
| {{ bots: '봇 | ', servers: '서버 | ' }[type] || ''}한국 디스코드 리스트 |
wonderlandpark
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.