Add Hyperplane and Ray API
#1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
edgarriba
commented
Oct 26, 2022
ducha-aiki
approved these changes
Oct 28, 2022
ducha-aiki
reviewed
Oct 28, 2022
|
|
||
|
|
||
| # NOTE: not very clear if this is a module or custom Tensor | ||
| # tensor subclass doesn't like to override methods |
There was a problem hiding this comment.
We should explore this https://colab.research.google.com/drive/1WiuUjznGVOyDvn03bt8ZUbCtGS8lqOBN
There was a problem hiding this comment.
/cc @stevenlovegrove for awareness— context is a discussion we had in slack to model a BaseVectorType to mimic Eigen::Vector , Eigen::Matrix, etc to build on top of that things like Vec2, Vec3, RotationMatrix, HomographyMatrix, ProjectionMatrix, etc.
also one attempt is did some time ago to model a Image api, that maybe we could align with new Sophus Image or pangolin : #1562
Only "drawback" is that will be pytorch only , while we have been recently exploring how to extend/adapt Kornia code to run given other backends like numpy/numba, triton, jax, etc
johnnv1
pushed a commit
to johnnv1/kornia
that referenced
this pull request
Apr 5, 2023
* initial commit for hyperplane * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixes and add tests * add fit_plane * add line plane intersection * add intersect mask * fix test * make Ray alias * jit ignore * remove line from plane for now * implement dot, squared_norm * add note comment * restore kornia check type * better message * undo jit ignore Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1753
Type of change
Checklist