Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lightglue example #70

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Added lightglue example #70

merged 5 commits into from
Nov 17, 2023

Conversation

ducha-aiki
Copy link
Member

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Nov 12, 2023

View / edit / reply to this conversation on ReviewNB

edgarriba commented on 2023-11-12T08:22:56Z
----------------------------------------------------------------

AdalamFilter is not used ?


Copy link

review-notebook-app bot commented Nov 12, 2023

View / edit / reply to this conversation on ReviewNB

edgarriba commented on 2023-11-12T08:22:56Z
----------------------------------------------------------------

As a follow up, I’d show the matches here too to compare the two strategies


Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. comments for follow up PR

@johnnv1 johnnv1 merged commit 189d746 into master Nov 17, 2023
3 checks passed
@johnnv1 johnnv1 deleted the lightglue branch November 17, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants