Track if logger was lazy or not #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tracking mechanism for logger's `opt` method. Thanks to that it is now possible to detect bad calls to logger that are lazy and are expecting `t.Callable[[], t.Any]` Closes: #6
Delgan
approved these changes
Jun 27, 2020
|
@kornicameister I tested it and it seems perfectly fine, congrats for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tracking mechanism for logger's
optmethod.Thanks to that it is now possible to detect bad calls to logger that
are lazy and are expecting
t.Callable[[], t.Any]Closes: #6