Copy labels as specified by copy_labels_pattern
#327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not clear how null as a default would behave from the Github Docs. However, the Docs are clear about what happens when an input is not provided when it is not required: it becomes an empty string.
It was attempting to add labels, even when it didn't find any to copy.
Not sure if this would actually cause any issues, but `[string]` is different from `string[]`. The latter is a string array, the first is an array consisting of 1 string element. This should've prevented us from passing an empty array and passing an array with multiple elements, but I guess this doesn't work too well in TS. It's also not what we want.
The default is an empty string, which disables the copy labels behavior. This input should also be documented in the trigger using a comment workflow example.
|
Tested successfully: results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new input
copy_labels_pattern.When set, the action copies labels from the original pull request to the created backport pull requests when they match the provided pattern (excluding labels matching the
label_pattern).By default, no labels are copied.
Many thanks to @lheckemann for this contribution. See #314.
Resolves #87