Test git module #374
Merged
Test git module #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to inject execa into git and to inject git into backport.
Inversion of control makes it easier to test backport.ts and git.ts.
I had to add a bit of a strange type for execa, using the import()
function. This is because execa does not provide the types in an easily
importable way. If you know of a better way to do this, please let me
know.
The idea of this type is to take the type of the import of execa, which
is an object that contains all the functions of the execa package.
```
type Execa = (typeof import("execa"))...
```
Then, we take the `execa` function from this object using an indexed
access type:
```
type Execa = ...["execa"]
```
Adds some tests to make sure git works as I expect
Adds another simple test case that shows that cherryPick can throw an error when it exits with a non-zero exit code.
It's not longer necessary to mock away execa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors parts of the code to make it easier to write tests, and adds several simple test cases for the git module.
This is part of an attempt to improve the testability of this project.