Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run on merged pull requests #40

Merged
merged 1 commit into from
May 25, 2021
Merged

Only run on merged pull requests #40

merged 1 commit into from
May 25, 2021

Conversation

korthout
Copy link
Owner

The pull_request [closed] event contains both merged and unmerged pull
requests. Since the bot now allows to trigger on comment, it has a build
in warning against being triggered for a unmerged pull request, but this
warning is also given when just closing a pull request.

This fixes this by further restricting when to trigger the action.

fixes #32

The pull_request [closed] event contains both merged and unmerged pull
requests. Since the bot now allows to trigger on comment, it has a build
in warning against being triggered for a unmerged pull request, but this
warning is also given when just closing a pull request.

This commit fixes this by further restricting when to trigger the action
@korthout korthout merged commit fffca39 into master May 25, 2021
@korthout korthout deleted the only-merged-pulls branch May 25, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't trigger on unmerged closed pull requests
1 participant