Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change condition to start a backport by comment #400

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

jschmid1
Copy link
Contributor

the contains expression can lead to unexpected action boot-loops when the error itself contains /backport.

This can be the case when a branch is includes the name "backport" like in this example comment

example error message .. in branch origin/backport-form-xx-to-xx

Using startsWith to reduce the likeliness of this issue. https://docs.github.com/en/actions/learn-github-actions/expressions#startswith

jschmid1 and others added 3 commits November 24, 2023 09:40
the `contains`  expression can lead to unexpected action boot-loops when the error itself contains `/backport`. 

This can be the case when a branch is includes the name "backport".

for example in a comment like this
```
error message .. in branch origin/backport-form-xx-to-xx
```

Using `startsWith` to reduce the likeliness of this issue.
https://docs.github.com/en/actions/learn-github-actions/expressions#startswith
the `contains`  expression can lead to unexpected action boot-loops when the error itself contains `/backport`.

This can be the case when a branch is includes the name "backport".

for example in a comment like this
```
error message .. in branch origin/backport-form-xx-to-xx
```

Using `startsWith` to reduce the likeliness of this issue.
https://docs.github.com/en/actions/learn-github-actions/expressions#startswith
Copy link
Owner

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jschmid1 🙇 I think this is a good idea

👍 LGTM

@korthout korthout merged commit b149012 into korthout:main Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants