Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to add original author as assignee #445

Merged
merged 2 commits into from
Feb 23, 2025

Conversation

soooch
Copy link
Contributor

@soooch soooch commented Feb 18, 2025

this is a very lazy change, but maybe a more general solution would be better. there's a whole NxM mapping here of [copy, author, merger, etc.] -> [assignee, reviewer]. so maybe a template expansion approach may be smart.

Copy link
Owner

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @soooch 🙌

💭 I see the benefit of a more flexible solution, but I'd welcome a dedicated add_author_as_assignee input, regardless, as this is a common use case. So, let's add it.

👍 LGTM

public async setAssignees(pr: number, assignees: string[], repo: Repo) {
public async addAssignees(pr: number, assignees: string[], repo: Repo) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good change!

@korthout korthout merged commit 881e8e0 into korthout:main Feb 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants