Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Referred issues placeholder #77

Merged
merged 4 commits into from
Jun 27, 2021
Merged

Referred issues placeholder #77

merged 4 commits into from
Jun 27, 2021

Commits on Jun 27, 2021

  1. feat(utils): add get mentioned issue refs from body 

    This method was hard to build due to the complications of working with
regex. However, because the entire method can work on a string and does
not require any other dependencies, it made sense to expose it as a
single exported function in a utils file. This made testing a lot
easier, because it does not require us to do any additional setup.

The tests are structured in a way to test the most common cases and the
helper method is created to allow the test code to focus on test cases.

In ES2020, string.matchAll is added which allows capturing groups of all
matches. Using this we would not have to execute the url pattern on each
individual matched url again to find the capture groups (which we use to
construct the issue reference). Sadly, ES2020 is not available in nodejs
12 which is used by default for github actions.
    @korthout
    korthout committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    a903dcc View commit details
    Browse the repository at this point in the history

  2. feat: support ${issue_refs} in pull description 

    The placeholder ${issue_refs} is replaced with all issues mentioned in
the original pull request's body. Urls are tranformed into actual GitHub
refs (like org/repo#number). External repo issue reference still refer
to the external repo. Finally, all indidividual references are seperated
by a space when used to replace the placeholder.
    @korthout
    korthout committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    b7d0d16 View commit details
    Browse the repository at this point in the history

  3. docs(README): describe issue_refs placeholder

    @korthout
    korthout committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    965dd5a View commit details
    Browse the repository at this point in the history

  4. dist: build new version

    @korthout
    korthout committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    e812bda View commit details
    Browse the repository at this point in the history