Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't kill created terminals #34

Closed
ceuk opened this issue May 3, 2021 · 3 comments
Closed

Can't kill created terminals #34

ceuk opened this issue May 3, 2021 · 3 comments

Comments

@ceuk
Copy link

ceuk commented May 3, 2021

Hey, the trash icons doesn't kill the terminal instance created by this extension, nor does typing exit. Is there a way to kill the shell after the command has executed?

e.g. currently a command like this:

curl http://some-site | less && exit will work as intended (i.e. it will open the site content in less and then run exit when you quit less). But as soon as that happens, a new terminal is launched. I would expect it to stay closed (and for the panel to close if there were no more active terminals)

@JCKodel
Copy link

JCKodel commented Mar 4, 2023

Same here. For some reason, it opens 2 or 3 run-in-terminal terminals. When I click on the trash bin to close it, it spawns some others. If I insist, it consumes 100% CPU and freezes VSCode.

@kortina
Copy link
Owner

kortina commented Mar 8, 2023

Hmm, not totally sure what is causing this behavior. If anyone has ideas on the root cause or fix, please add context and feel free to submit a PR.

I seem to be able to intermittently duplicate by creating the following file, making it executable, and running it:

#!/usr/bin/env python
import time
time.sleep(10.0)

Sometimes (I can't tell exactly when and when not) upon doing this, when I click the Trash icon, it just creates another terminal instead of closing the existing terminal.

@Lopol2010
Copy link

@kortina review my bugfix pls #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants