Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't kill terminal #41

Closed
wants to merge 1 commit into from
Closed

Conversation

Lopol2010
Copy link

@Lopol2010 Lopol2010 commented Mar 31, 2023

should fix the issue #34

as I understand bug happens because only name checked, so everything is screwed when you got more than one terminal called 'run-in-terminal', which could happen when you reopening editor and everytime use the extension it will open up new terminal and not reuse old one.

@kortina
Copy link
Owner

kortina commented Mar 31, 2023

OK, great to know about this processId thing. I checked out the branch, still get the buggy behavior, but I think you gave me an idea for how to solve... Will try to fix this weekend.

@kortina
Copy link
Owner

kortina commented Mar 31, 2023

#42 replaces this PR. Thank you for the pull request! I'll get the change based on your work out soon.

@kortina kortina closed this Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants