Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag explorer needs Chinese words support #115

Closed
caihao opened this issue Jan 1, 2021 · 2 comments
Closed

Tag explorer needs Chinese words support #115

caihao opened this issue Jan 1, 2021 · 2 comments

Comments

@caihao
Copy link

caihao commented Jan 1, 2021

Describe the bug
Tag explorer does not support Chinese words, for example

#量子力学 #薛定谔方程

Screenshots
tags
There are only English tags.

Versions

  • OS: win10
  • VS Code Version: 1.52.1
  • Extension Version: v0.0.21
@thomaskoppelaar
Copy link
Contributor

Hi @caihao ,

I think I've implemented a solution: use \p{L} rather than \w for capturing letters.

See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions/Unicode_Property_Escapes

Fortunately, this means that only a few lines of code need to change (namely the pattern and the flags), and that should suffice.

I'll bundle this into PR #119 , seeing as that also makes changes to the tag pattern(s).

@kortina
Copy link
Owner

kortina commented Jan 24, 2021

Closed by #119

@kortina kortina closed this as completed Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants