Improved tag recognition, Chinese character support #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headings that are part of a URL don't get recognized as tags anymore.
thomaskoppelaar
changed the title
kortina
approved these changes
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headings that are part of a URL don't get recognized as tags anymore, and adds support for chinese characters in tags.
Closes: #114 , #115
URLs
I created this request after reading @frankreporting issue. Credit goes to him for the regex.
A possible addition to this PR could be to make this a configurable option, in case that someone does use URL headings as tags. I highly doubt it though, and this seems like a great improvement to this extension.
Chinese character support
Also a very short change in some regex patterns: Mainly changing instances of
\winto\p{L}, which captures all unicode letters rather than letters from the latin alphabet. also sets the unicode flagufor some regex patterns.