Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow autocompletion inside an empty wiki link #99

Closed
yamnikov-oleg opened this issue Sep 30, 2020 · 3 comments
Closed

Allow autocompletion inside an empty wiki link #99

yamnikov-oleg opened this issue Sep 30, 2020 · 3 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed next

Comments

@yamnikov-oleg
Copy link

Is your feature request related to a problem? Please describe.
I tried to autocomplete wiki links in my workspace and couldn't make it work at first. I have tried:

  • Inserting an empty link [[ and opening autocomplete options, but there were no notes there.
  • Inserting a dot inside an empty link as the README gifs suggest, but couldn't actually find my notes, because VS Code thinks that the dot is part of the search query. So if I'm trying to link to My note.md and I type [[.mynote]], the note I want doesn't match ".mynote" query because of the dot in front.

Describe the solution you'd like
I would like to be able to open autocomplete options inside of an empty link ([[]])

Describe alternatives you've considered
The workaround I'm using is typing several characters of the notes name first, then opening autocompletion. For the example above I would type [[mynote]] then press Ctrl+Space.

Additional context
I have poked around the source code and have managed to accomplish what I mean with these edits: yamnikov-oleg@658c390

I can create a PR, but I'm not sure if that solution is correct and won't break anything.

@lucabol
Copy link

lucabol commented Nov 6, 2020

fyi I am having the same issue. I use timestamp ids as file name and nothing appears after I type [[ and invoke CTRL+SPACe.

@kortina
Copy link
Owner

kortina commented Nov 11, 2020

@yamnikov-oleg this was always very annoying to me -- would be awesome if your change fixes it!

Do all the tests still pass w your change set?

Have you been using the forked version / have you noticed any other potential issues?

@kortina
Copy link
Owner

kortina commented Jan 24, 2021

Closed by #122

@kortina kortina closed this as completed Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed next
Projects
None yet
Development

No branches or pull requests

3 participants