return all possible wiki links or tags as soon as suggest is triggered for [[ or # #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortina
changed the title
kortina
commented
Jan 24, 2021
| @@ -57,11 +62,7 @@ export class Note { | |||
| fsPath: string; | |||
| data: string | undefined; | |||
| refCandidates: Array<RefCandidate> = []; | |||
| title: { | |||
There was a problem hiding this comment.
This was suddenly error-ing, some sort of linter issue. I resolved by declaring a new type.
Also, this file got a lot of linter diff lines.
kortina
commented
Jan 24, 2021
| @@ -70,8 +70,8 @@ export class NoteWorkspace { | |||
| // This will allow us to potentially expose these as settings. | |||
| // Note for the future: \p{L} is used instead of \w , in order to match to all possible letters | |||
| // rather than just those from the latin alphabet. | |||
| static _rxTagNoAnchors = '(?<= |,|^)#[\\p{L}\\-_]+'; // used to match tags that appear within lines | |||
| static _rxTagWithAnchors = '^#[\\p{L}\\-_]+$'; // used to match entire words | |||
There was a problem hiding this comment.
_rxTagNoAnchorsis now_rxTag_rxTagWithAnchorswas never used_rxBeginTagnow allows matching an empty tag#with the allowed preceding chars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #99.
Typing
[[then doingtriggerSuggestwill suggest all possible wiki links. Typing#then doingtriggerSuggestwill suggest all possible tags.