Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecraft 1.20.4 support. #13

Closed
wants to merge 1 commit into from
Closed

Minecraft 1.20.4 support. #13

wants to merge 1 commit into from

Conversation

indaqoo
Copy link

@indaqoo indaqoo commented Mar 4, 2024

Hi,

WallMountLocation was renamed to BlockFace.
This will fix the /geodesy analyze command issue with 1.20.4 versions.

@indaqoo indaqoo mentioned this pull request Mar 4, 2024
@kosma
Copy link
Collaborator

kosma commented Mar 4, 2024

Thank you ❤️ I will merge this soon, I need to take a good look at the version support situation.

@ruben2s
Copy link

ruben2s commented Mar 10, 2024

Hi, any chance this is going to get published soon? Github actions seems to not have any build available to download regarding this change.

Thanks!

@indaqoo
Copy link
Author

indaqoo commented Mar 10, 2024

Hi, any chance this is going to get published soon? Github actions seems to not have any build available to download regarding this change.

Thanks!

Hi @ruben2s,
I think you could clone this repo and build it yourself until @kosma has done all required version support checks, etc.

@kosma
Copy link
Collaborator

kosma commented Mar 29, 2024

Fixed in 61b9264. Couple of notes:

  1. The offending change wasn't the rename of WallMountLocation to BlockFace (that's a Yarn named rename, those are harmless), it was a hard to explain intermediary rename of Blocks.PUMPKIN from field_10261 to field_46282. Go figure.
  2. The change was done in 1.20.3 but the mod works on both .3 and .4 now.

@kosma kosma closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants