Add VS_ENV.with_env(&) method to enable setting up Visual Studio Envi… #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ronment for windows For building on windows, sets up a Visual Studio x64 Environment, so that developer tools are available
|
this is crashed on ci: https://github.com/kostya/lexbor/actions/runs/6497657533/job/17648994221 |
With VS_ENV.with_env, no longer need these steps
|
With the change to the workflow in the latest push, this works. I just tested it. |
|
need to change the workflow - If you look at this workflow run in my vs_env branch, https://github.com/dsisnero/lexbor/blob/vs_env/.github/workflows/win_vsenv.yml , I remove this action ilammy/msvc-dev-cmd@cec98b9 because it is no longer needed with the |
kostya
reviewed
Oct 16, 2023
| - name: Enable Windows developer prompt | ||
| uses: ilammy/msvc-dev-cmd@cec98b9d092141f74527d0afa6feb2af698cfe89 | ||
|
|
||
| - name: Setup cmake |
|
My changes do the same thing as msvc-dev-cmd, that is what the crystal code
in VS_ENV does, it is a Crystal equivalent version of the msvc-dev-cmd
action. This enables users that use lexbor not having to open up a
msvc-dev-cmd manually. Otherwise the person who uses your library on
windows has to know to open a msvc-dev-cmd prompt before using Crystal
lexbor and tools like https://github.com/kojix2/chatgpt-cli cannot be
compiled by just doing shards build --release.
Again, my code changes does the exact same thing as the msvc-dev-cmd, only
in Crystal
…On Mon, Oct 16, 2023 at 3:06 PM Kostya M ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/win.yml
<#37 (comment)>:
> @@ -12,13 +12,6 @@ jobs:
runs-on: windows-2022
steps:
- - name: Enable Windows developer prompt
- uses: ***@***.***
-
- - name: Setup cmake
why you remove cmake?
—
Reply to this email directly, view it on GitHub
<#37 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABQRLEXS2JSNB2PLXCBHTX7WOUPAVCNFSM6AAAAAA55ZKIL6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOBQHE2TSOBRG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
but why actions still crash? https://github.com/kostya/lexbor/actions/runs/6512196611/job/17704923602 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For building on windows, sets up a Visual Studio x64 Environment, so that developer tools are available