Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated files to pass curly and bitwise tests in jshint #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iticus
Copy link

@iticus iticus commented Jun 16, 2016

I tried to build the project using the instructions provided (by using grunt more specifically) but I got errors such as
[L152:C17] W116: Expected '{' and instead saw 'continue'
I fixed the code to conform with JSHint's curly option (by adding curly braces even when the block consists of only one statement) and bitwise option (by adding /*jslint bitwise: true */).
Using these modifications I'm able to build the project successfully.

@mourner
Copy link
Contributor

mourner commented Jun 16, 2016

Would it be easier to disable the rules in JSHint?
BTW we should switch to ESLint anyway, no one uses JSHint in the JavaScript world anymore.

@iticus
Copy link
Author

iticus commented Jun 16, 2016

It would probably be easier to just disable the rules (options), however using the curly brackets makes the code less error-prone. Being more explicit about using the bitwise operators helps too in my opinion.
Regarding ESLint vs JSHint I don't have an opinion yet as I don't have much experience with them.

@DerDakon
Copy link
Collaborator

Whatever we do, we should be consistent. Currently the setup says that lint thing should be fine, but it is not. So either we drop it now or we fix the code now, either is fine with me (I'm not a JS guy anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants