Don't clear static flags in resetWorkInProgress

Fixes the regression test added in facebook#20433
koto · Jun 15, 2021 · 3a2e8d8 · 3a2e8d8
1 parent 9691712
commit 3a2e8d8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/react-reconciler/src/ReactFiber.new.js b/packages/react-reconciler/src/ReactFiber.new.js
@@ -365,7 +365,7 @@ export function resetWorkInProgress(workInProgress: Fiber, renderLanes: Lanes) {
 
  // Reset the effect flags but keep any Placement tags, since that's something
  // that child fiber is setting, not the reconciliation.
- workInProgress.flags &= Placement;
+ workInProgress.flags &= StaticMask | Placement;
 
  // The effect list is no longer valid.
  workInProgress.nextEffect = null;

diff --git a/packages/react-reconciler/src/ReactFiber.old.js b/packages/react-reconciler/src/ReactFiber.old.js
@@ -365,7 +365,7 @@ export function resetWorkInProgress(workInProgress: Fiber, renderLanes: Lanes) {
 
  // Reset the effect flags but keep any Placement tags, since that's something
  // that child fiber is setting, not the reconciliation.
- workInProgress.flags &= Placement;
+ workInProgress.flags &= StaticMask | Placement;
 
  // The effect list is no longer valid.
  workInProgress.nextEffect = null;