Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http server with data structures #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

assmass13
Copy link

Http server with data structures is developed

Copy link
Member

@OleksiyRudenko OleksiyRudenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@assmass13 good job!
However your commit affects demo files added by @AMashoshyna :

  • removes submissions/amashoshyna/port-sniffer/index.js
  • removes submissions/amashoshyna/port-sniffer/README.md

The above means these files will be no longer available for future contributors which is not really nice.

Please fix the issue.

Copy link
Member

@AMashoshyna AMashoshyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a small exception of await the code looks great! Please fix linting issues (they are all auto-fixable)

});
});

const parseJson = async req => readBody(req).then(JSON.parse);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

async keyword is usually not needed when you don't use await.

};
}

async postStackRoute(req, res) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: async keyword is redundant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants