chore(sdk): place Android notification channel under the android object

koush · Oct 25, 2024 · 9edb752 · 9edb752
1 parent 38f7c14
commit 9edb752
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/plugins/diagnostics/src/main.ts b/plugins/diagnostics/src/main.ts
@@ -128,7 +128,9 @@ class DiagnosticsPlugin extends ScryptedDeviceBase implements Settings {
             await device.sendNotification('Scrypted Diagnostics', {
                 body: 'Body',
                 subtitle: 'Subtitle',
-                channel: 'diagnostics',
+                android: {
+                    channel: 'diagnostics',
+                }
             }, mo);
 
             this.warnStep(console, 'Check the device for the notification.');

diff --git a/sdk/types/scrypted_python/scrypted_sdk/types.py b/sdk/types/scrypted_python/scrypted_sdk/types.py
@@ -643,13 +643,16 @@ class MediaStreamOptions(TypedDict):
     tool: MediaStreamTool  # The tool was used to write the container or will be used to read teh container. Ie, scrypted, the ffmpeg tools, gstreamer.
     video: VideoStreamOptions
 
+class AndroidNotificationOptions(TypedDict):
+    channel: str
+
 class NotifierOptions(TypedDict):
 
     actions: list[NotificationAction]
+    android: AndroidNotificationOptions
     badge: str
     body: str
     bodyWithSubtitle: str
-    channel: str
     data: Any
     dir: NotificationDirection
     image: str

diff --git a/sdk/types/src/types.input.ts b/sdk/types/src/types.input.ts
@@ -225,7 +225,9 @@ export interface NotifierOptions {
   badge?: string;
   bodyWithSubtitle?: string;
   body?: string;
-  channel?: string;
+  android?: {
+    channel?: string;
+  }
   data?: any;
   dir?: NotificationDirection;
   lang?: string;