feat(sdk): add support for notification channel in NotifierOptions #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koush
reviewed
Oct 25, 2024
koush
reviewed
Oct 25, 2024
This change spins off from conversation at scryptedapp/homeassistant#1 and allows consumers of the `Notifier` interface to specify a channel for notifications to be sent to. Android platforms can use this to send notifications to a specific channel, allowing the user to have fine-grained control over the audio and priority of the notifications they receive.
USA-RedDragon
force-pushed
the
notification-channels
branch
from
85ae53d
to
8ed7dec
Compare
USA-RedDragon
force-pushed
the
notification-channels
branch
from
8ed7dec
to
564283e
Compare
|
looks good |
|
published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change spins off from conversation at scryptedapp/homeassistant#1 and allows consumers of the
Notifierinterface to specify a channel for notifications to be sent to. Android platforms can use this to send notifications to a specific channel, allowing the user to have fine-grained control over the audio and priority of the notifications they receive.I'm not certain my
automation-actions.tsedit is enough to make this work, I didn't readily see where these were consumed in the codebase.Potential TODOs:
manage.scrypted.app- Should the frontend test notification set a channel oftestingor should it stay with the general channel? https://github.com/koush/manage.scrypted.app/blob/168317f6790e7012560e7d2bb755c6fd03c0a308/src/components/interfaces/Notifier.vue#L97scryptedapp/notifier-zone-filter- https://github.com/scryptedapp/notifier-zone-filter/blob/64d1d8130912ccab73c4e360db5cce757ccea1d6/src/main.py#L457 and https://github.com/scryptedapp/notifier-zone-filter/blob/64d1d8130912ccab73c4e360db5cce757ccea1d6/src/main.py#L460scryptedapp/securitysystem- https://github.com/scryptedapp/securitysystem/blob/cd82bbde8a2414e738a035248e4646c3102e3221/src/main.ts#L129