Remove RTMP streams for nvr connected cams

plugins/reolink/README.md

@@ -5,10 +5,13 @@ Reolink Cameras offer both RTMP and RTSP streams. RTMP streams are more reliable
 ## Feature Support
 
     * Reolink Cameras
-        * Two Way Audio - Reolink Two Way Audio is not supported. It is a proprietary and undocumented protocol.
+        * PTZ - Supported for most of the reolink cameras in the Advanced section. ONVIF PTZ plugin won't work correctly 
+        * Two Way Audio - Reolink Two Way Audio is not supported. It is a proprietary and undocumented protocol. For a few cameras it is available through the Advanced section (confirmed working on E1 zoom, E1 outdoor, E1 POE, RLC-540A)
     * Reolink Doorbells
         * Enable the Doorbell checkbox in the Scrypted settings for the Reolink device.
         * The Reolink Doorbell supports two way audio via ONVIF. Reolink Cameras do not support this feature.
+    * Reolink Trackmix
+        * All the RTSP streams are provided within the same camera. The camera should be added only with the channel 0 twice and select the appropriate streams
 
 Some Reolink cameras support the ONVIF protocol. It may be worth experimenting with the ONVIF plugin instead. Using the Reolink Plugin is generally recommended due to the additional stream that is made available.
 

plugins/reolink/src/main.ts

@@ -703,21 +703,29 @@ class ReolinkCamera extends RtspSmartCamera implements Camera, DeviceProvider, R
         // anecdotally, encoders of type h265 do not have a working RTMP main stream.
         const mainEncType = this.storageSettings.values.abilities?.value?.Ability?.abilityChn?.[rtspChannel].mainEncType?.ver;
 
-        if (live === 2) {
-            if (mainEncType === 1) {
-                streams.push(rtmpSub, rtspMain, rtspSub);
+
+        if (deviceInfo.isNvr) {
+            // NVR connected cameras are very unstable on the RTMP stream, keep only the ext to have a 3th stream
+            streams.push(rtspMain, rtspSub);
+            if(mainEncType === 1) {
+                streams.push(rtmpExt);
+            }
+        } else {
+            if (live === 2) {
+                if (mainEncType === 1) {
+                    streams.push(rtmpSub, rtspMain, rtspSub);
+                }
+                else {
+                    streams.push(rtmpMain, rtmpSub, rtspMain, rtspSub);
+                }
+            }
+            else if (mainEncType === 1) {
+                streams.push(rtmpExt, rtmpSub, rtspMain, rtspSub);
             }
             else {
-                streams.push(rtmpMain, rtmpSub, rtspMain, rtspSub);
+                streams.push(rtmpMain, rtmpExt, rtmpSub, rtspMain, rtspSub);
             }
         }
-        else if (mainEncType === 1) {
-            streams.push(rtmpExt, rtmpSub, rtspMain, rtspSub);
-        }
-        else {
-            streams.push(rtmpMain, rtmpExt, rtmpSub, rtspMain, rtspSub);
-        }
-
 
         // https://github.com/starkillerOG/reolink_aio/blob/main/reolink_aio/api.py#L93C1-L97C2
         // single motion models have 2*2 RTSP channels

plugins/reolink/src/probe.ts

@@ -25,6 +25,7 @@ export interface DevInfo {
     serial: string;
     type: string;
     wifi: number;
+    isNvr?: boolean;
 }
 
 async function getDeviceInfo(host: string, username: string, password: string): Promise<DevInfo> {

plugins/reolink/src/reolink-api.ts

@@ -235,8 +235,10 @@ export class ReolinkCameraClient {
 
         const deviceInfo: DevInfo = await response.body?.[0]?.value?.DevInfo;
 
+        const isNvr = ['HOMEHUB', 'NVR', 'NVR_WIFI'].includes(deviceInfo.exactType);
+        deviceInfo.isNvr = isNvr;
         // Will need to check if it's valid for NVR and NVR_WIFI
-        if (!['HOMEHUB', 'NVR', 'NVR_WIFI'].includes(deviceInfo.exactType)) {
+        if (!isNvr) {
             return deviceInfo;
         }