Buildsystem update #14
Conversation
DotBlack
commented
Mar 22, 2024
DotBlack
commented
- Fixed building errors for windows
- Added the option to build for debian systems
Keeping these link_options active results in aborting build processes.
Uses the latest emsdk now
|
The WASM build is failed is failed, could you please check it? |
CMakeLists.txt
Outdated
| target_link_options (AssimpJS PUBLIC -sSTACK_SIZE=10MB) | ||
| target_link_options (AssimpJS PUBLIC -sALLOW_MEMORY_GROWTH=1 --no-heap-copy) | ||
| target_link_options (AssimpJS PUBLIC -sNO_DISABLE_EXCEPTION_CATCHING) | ||
| # target_compile_options (AssimpJS PUBLIC "$<$<CONFIG:Debug>:-gsource-map>") |
There was a problem hiding this comment.
Why do you think these are not needed?
There was a problem hiding this comment.
I deactivated the link_options because it is not building.
I'm getting this error for example:
em++: error: Attempt to set a non-existent setting: 'STACK_SIZE'
- did you mean one of STACK_BASE, ASYNCIFY_STACK_SIZE, STACK_MAX?
- perhaps a typo in emcc's -s X=Y notation?
Seems like this option is invalid.
Currently you set the emsdk version to build with version 3.1.35.
The changelog states that this option was removed with version 3.1.31. Link
I will update my pullrequest soon with reactivated link options.
tools/setup_emscripten_win.bat
Outdated
|
|
||
| call git clone https://github.com/emscripten-core/emsdk.git | ||
| call cd emsdk | ||
| ::call emsdk install 3.1.35 |
There was a problem hiding this comment.
It is intentionally tied to a fixed version so every developer has the exact same environment. If you would like to update, please use the latest fixed version.
There was a problem hiding this comment.
I changed the script to use the latest fixed version.
|
Thank you for the changes! |
