Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIP-4: "create2" Host Function for pWASM #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sorpaas
Copy link

@sorpaas sorpaas commented Jul 18, 2018

rel openethereum/parity-ethereum#9139

(Rendered)

I found no other KIPs in this repo for reference, so please let me know if anything's not right.

@NikVolf
Copy link

NikVolf commented Jul 30, 2018

There might be no regular create ever used on chain, so we might as well replace the behaviour of regular create?

@sorpaas
Copy link
Author

sorpaas commented Aug 1, 2018

@NikVolf I'm worried it might break consensus. At any moment that assumption may be broken because deploying a contract using create on Kovan is trivial..

@NikVolf
Copy link

NikVolf commented Aug 21, 2018

can this also be updated to avoid mentioning id-s (like #6)? (i cant do it myself, since it's pr from fork)

also CREATE2 should be create2, since wasm imports are not capitalized

@sorpaas sorpaas changed the title KIP-4: CREATE2 Host Function for pWASM KIP-4: create2 Host Function for pWASM Aug 21, 2018
@sorpaas
Copy link
Author

sorpaas commented Aug 21, 2018

Done!

@sorpaas sorpaas changed the title KIP-4: create2 Host Function for pWASM KIP-4: "create2" Host Function for pWASM Aug 21, 2018
@lexfrl
Copy link

lexfrl commented Aug 22, 2018

Please, don't forget to update the docs https://paritytech.github.io/pwasm-ethereum/pwasm_ethereum/ (enable kip4 feature) when the KIP will be merged and fork will be enabled.

@5chdn
Copy link

5chdn commented Sep 30, 2018

KIP 4 will be activated on Kovan block 9_200_000, please finalize and merge spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants