Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mermaid via library #288

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

mrueg
Copy link
Collaborator

@mrueg mrueg commented Apr 24, 2023

This MR is based on and will replace: #167
Kudos to @dreampuf for the initial implementation

  • Adding Mermaid support via mermaid.go, allowing to render it locally.
  • Adding new optional arguments to ac:image namely: Title, Heigth attributes
  • Switching docker image base to headless-shell

@mrueg mrueg requested a review from kovetskiy April 24, 2023 18:49
@mrueg mrueg force-pushed the add-mermaid-support branch 5 times, most recently from c09977a to c551910 Compare April 24, 2023 22:33
@mrueg mrueg force-pushed the add-mermaid-support branch 2 times, most recently from fe37ac7 to d328171 Compare April 25, 2023 21:33
Implementation is largely based on: kovetskiy#167

Co-Authored-By: Manuel Rueger <manuel@rueg.eu>
@mrueg mrueg force-pushed the add-mermaid-support branch from d328171 to 03c22da Compare April 25, 2023 21:37
@mrueg mrueg merged commit d9d560e into kovetskiy:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants