Make the attributes id and has_cover 'official' calibre metadata … #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibutes. This allows them to be copied by deepcopy_metadata().
The problem was exposed by a kiwidude plugin "Search the Internet". After a deepcopy_metadata() a template using "{id}" failed with "unknown field".
I don't think this change will break anything. If you are worried then reject the PR. The problem has been there since forever, so it clearly is not a burning problem.
|
I dont think this is a good idea, it's very widely used and predicting all the effects of the change is very difficult. There is already db_id for the book_id. Maybe the template language can be changed to fallback to that if id is missing? Also your commit seems to add only id not has_cover. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…attributes. This allows them to be copied by mi.deepcopy_metadata().
The problem was exposed by a kiwidude plugin "Search the Internet". After a deepcopy_metadata() a template using '{id}' failed with 'unknown field'.
I don't think this change will break anything. If you are worried then reject the PR. The problem has been there since forever, so it clearly is not a burning problem.