Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate custom HLint rules to a newer dhall spec (latest version: 10.0.0) #148

Closed
1 of 2 tasks
chshersh opened this issue Mar 1, 2019 · 0 comments · Fixed by #199
Closed
1 of 2 tasks

Migrate custom HLint rules to a newer dhall spec (latest version: 10.0.0) #148

chshersh opened this issue Mar 1, 2019 · 0 comments · Fixed by #199
Assignees
@vrom911
Labels
hlint
Milestone
v0.6.0.0: Refinement

Comments

@chshersh
Copy link
Contributor

chshersh commented Mar 1, 2019 •
edited by vrom911
Loading

What can be done:

  • Remove usages of constructor keyword (it became redundant)
  • Remove redundant in in let ... in expressions

More details here:

This is not urgent. Mostly minor refactorings that doesn't change functionality. It is probably a good idea to accumulate more changes and change more at once.
@chshersh chshersh added the hlint label Mar 1, 2019
@chshersh chshersh changed the title Migrate to newer dhall spec (latest version: 5.0.0) Migrate custom HLint rules to a newer dhall spec (latest version: 5.0.0) Mar 1, 2019
@chshersh chshersh changed the title Migrate custom HLint rules to a newer dhall spec (latest version: 5.0.0) Migrate custom HLint rules to a newer dhall spec (latest version: 6.0.0) Mar 6, 2019
@chshersh chshersh changed the title Migrate custom HLint rules to a newer dhall spec (latest version: 6.0.0) Migrate custom HLint rules to a newer dhall spec (latest version: 7.0.0) Apr 29, 2019
@chshersh chshersh added this to the v0.6.0.0: Refinement milestone Jul 5, 2019
@chshersh chshersh changed the title Migrate custom HLint rules to a newer dhall spec (latest version: 7.0.0) Migrate custom HLint rules to a newer dhall spec (latest version: 8.0.0) Jul 5, 2019
@chshersh chshersh changed the title Migrate custom HLint rules to a newer dhall spec (latest version: 8.0.0) Migrate custom HLint rules to a newer dhall spec (latest version: 9.0.0) Jul 25, 2019
@chshersh chshersh changed the title Migrate custom HLint rules to a newer dhall spec (latest version: 9.0.0) Migrate custom HLint rules to a newer dhall spec (latest version: 10.0.0) Sep 6, 2019
@vrom911 vrom911 mentioned this issue Sep 11, 2019
Merged
10 tasks
@vrom911 vrom911 self-assigned this Sep 29, 2019
vrom911 added a commit that referenced this issue Oct 2, 2019
@vrom911
[#148] Migrate custom HLint rules to a newer dhall spec (latest versi…
1119a6c 
…on: 10.0.0)

Resolves #148
@vrom911 vrom911 mentioned this issue Oct 2, 2019
Merged
chshersh pushed a commit that referenced this issue Oct 2, 2019
@vrom911 @chshersh
[#148] Migrate custom HLint rules to a newer dhall spec (latest versi…
cd4ff79 
…on: 10.0.0) (#199)

Resolves #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
hlint
Projects
None yet
Milestone
v0.6.0.0: Refinement
Development

Successfully merging a pull request may close this issue.

[#148] Migrate custom HLint rules to a newer dhall spec kowainik/relude
2 participants
@chshersh @vrom911