Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move property-based tests from 'doctest' to 'hedgehog' for the 'One' typeclass #281

Closed
chshersh opened this issue May 13, 2020 · 0 comments · Fixed by #288
Closed

Move property-based tests from 'doctest' to 'hedgehog' for the 'One' typeclass #281

chshersh opened this issue May 13, 2020 · 0 comments · Fixed by #288
Assignees
@vrom911
Labels
doc README, Haddock documentation, tutorials refactoring tests
Milestone
v0.7.0.0: Refiner

Comments

@chshersh
Copy link
Contributor

This forces us to have QuickCheck dependency, that needs to be suppressed. And also makes doctest very slow. So I guess, since we have a normal test-suite and since the law is already written in the docs, we can move those tests to hspec-hedgehog.
@chshersh chshersh added refactoring doc README, Haddock documentation, tutorials tests labels May 13, 2020
@chshersh chshersh added this to the v0.7.0.0: Refiner milestone May 13, 2020
@vrom911 vrom911 self-assigned this May 13, 2020
vrom911 added a commit that referenced this issue May 13, 2020
@vrom911
[#281] Move property-based tests from 'doctest' to 'hedgehog' for the…
87fea85 
… 'One' typeclass

Resolves #281
@vrom911 vrom911 mentioned this issue May 13, 2020
Merged
chshersh pushed a commit that referenced this issue May 13, 2020
@vrom911
[#281] Move One property tests from 'doctest' to 'hedgehog' (#288)
b27da98 
* [#281] Move property-based tests from 'doctest' to 'hedgehog' for the 'One' typeclass

Resolves #281

* Remove redundant warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
doc README, Haddock documentation, tutorials refactoring tests
Projects
None yet
Milestone
v0.7.0.0: Refiner
Development

Successfully merging a pull request may close this issue.

[#281] Move One property tests from 'doctest' to 'hedgehog' kowainik/relude
2 participants
@chshersh @vrom911