[#121] Reexport Ap and change foldMapA #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we still need some explicit Semigroup constraints for the older GHC versions... |
cronokirby
reviewed
Feb 16, 2019
vrom911
reviewed
Feb 16, 2019
src/Relude/Monoid.hs
Outdated
| minBound = pure minBound | ||
| maxBound = pure maxBound | ||
|
|
||
| -- | @since 4.12.0.0 |
There was a problem hiding this comment.
Should we use relude versions here? Does it make sense to write about base versions?
There was a problem hiding this comment.
Good point! I will update the docs 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #121
I didn't touch
foldMapMfor now. Probably it should be implemented usingfoldMap'from newer base.