Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#127] Add Lens module #152

Merged
merged 3 commits into from
Mar 17, 2019
Merged

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Mar 17, 2019

Resolves #127

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

@vrom911 vrom911 added enhancement New feature or request doc README, Haddock documentation, tutorials extra Relude.Extra labels Mar 17, 2019
@vrom911 vrom911 self-assigned this Mar 17, 2019
@vrom911 vrom911 force-pushed the vrom911/127-Implement-ReludeExtraLens-module branch from ddf633d to 7adef51 Compare March 17, 2019 09:54
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@vrom911 vrom911 force-pushed the vrom911/127-Implement-ReludeExtraLens-module branch from 7adef51 to fbf0018 Compare March 17, 2019 13:06
Copy link
Collaborator

@cronokirby cronokirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it integrates pretty smoothly with the other libraries, nice ;)

@chshersh chshersh merged commit b87f281 into master Mar 17, 2019
@chshersh chshersh deleted the vrom911/127-Implement-ReludeExtraLens-module branch March 17, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc README, Haddock documentation, tutorials enhancement New feature or request extra Relude.Extra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants