Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inifintely #331

Merged
merged 12 commits into from
Oct 7, 2020
Merged

Add inifintely #331

merged 12 commits into from
Oct 7, 2020

Conversation

aleator
Copy link
Contributor

@aleator aleator commented Sep 9, 2020

Resolves #327

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

hint-man[bot]
hint-man bot reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why your PR is still not approved? Because I chose not to approve it. But they will.

src/Relude/Monad.hs Outdated Show resolved Hide resolved
src/Relude/Monad.hs Outdated Show resolved Hide resolved
src/Relude/Monad.hs Outdated Show resolved Hide resolved
@aleator @hint-man
Drop trailing whitespace
8460021 
Co-authored-by: hint-man[bot] <44720633+hint-man[bot]@users.noreply.github.com>
chshersh
chshersh reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleator Thanks for working on this! Looking great 👍
I have a few suggestions, but they are mostly stylistic, nothing criticial.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
hlint/hlint.dhall Show resolved Hide resolved
src/Relude/Monad.hs Outdated Show resolved Hide resolved
src/Relude/Monad.hs Show resolved Hide resolved
@chshersh chshersh added the new Bring something new into library (add function or type or interface) label Sep 16, 2020
aleator and others added 3 commits September 30, 2020 10:43
@aleator @chshersh
Update src/Relude/Monad.hs
7396485 
Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>
@aleator @chshersh
Update CHANGELOG.md
11fc26e 
Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>
@aleator @chshersh
Update CHANGELOG.md
3f43603 
Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>
vrom911
vrom911 approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing addition! ✨

And thank for the nice docs and HLing hints as well 👍🏼

@vrom911 vrom911 merged commit fe21aef into kowainik:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh left review comments

@hint-man hint-man hint-man left review comments

@vrom911 vrom911 vrom911 approved these changes

Assignees

@aleator aleator

Labels
new Bring something new into library (add function or type or interface)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could forever be Applicative f => f a -> Void instead?
3 participants
@aleator @chshersh @vrom911