-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --disable-timestamp
#324
Conversation
@koxudaxi |
fastapi_code_generator/__main__.py
Outdated
# timestamp: {timestamp}""" | ||
# filename: {Path(input_name).name}""" | ||
if not disable_timestamp: | ||
header += f"timestamp: {timestamp}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ytoml
The first position needs a new line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ytoml
Thank you for creating the PR.
Could please add the unittest for the option?
@koxudaxi |
Codecov ReportBase: 91.01% // Head: 91.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 91.01% 91.09% +0.07%
==========================================
Files 5 5
Lines 345 348 +3
==========================================
+ Hits 314 317 +3
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hello, I want this CLI to have
--disable-timestamp
option likedatamodel-codegen
does thus implemented.I'll be grad if this PR is accepted! Thank you.