Feature/generate routers #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: fix .model to ..model in imports.py visitor
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 91.09% 91.90% +0.81%
==========================================
Files 5 6 +1
Lines 348 383 +35
==========================================
+ Hits 317 352 +35
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
koxudaxi
reviewed
Apr 27, 2023
fastapi_code_generator/__main__.py
Outdated
Comment on lines
66
to
69
| # if generate_routers: | ||
| # template_dir = BUILTIN_MODULAR_TEMPLATE_DIR | ||
| # Path(output_dir / "routers").mkdir(parents=True, exist_ok=True) | ||
|
|
There was a problem hiding this comment.
Should we remove the commented lines?
There was a problem hiding this comment.
Of course.
I removed it.
|
@v1kAn0v |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello koxudaxi,
Let me introduce myself first.
I am Data Engineer working for an Elbit Systems (Israeli Company)
We widely use your fastapi-code-generator in one of our application API's.
I faced necessarily to split large API main.py into routers grouped by Tags corresponding to same model.py, using shared dependencies.py and routed to single main.py (as it recommended by tiangolo FastAPI APIRouter() approach here
I would like to contribute code I have developed so your code generator will support this feature with ease.
I believe it will help many developers across the globe enhance capabilities of their applications and allow to maintain it with ease when large application could be split apart based on tags defined in swagger .yaml. No need to regenerate entire main, only endpoints with tags you only intend to change. I think it could be great contribution to your code and to entire community.
I'll appreciate you will add me as a contributor to your project.
The code passed tests, format and doesn't affect your overall coverage. For more details please see README.md with explanations of usage.
Great day and thank You